feat: add crossOriginLoading option support#313
Conversation
|
|
ooflorent
left a comment
ooflorent
left a comment
There was a problem hiding this comment.
I like the idea on reusing crossOriginLoading option but I don't like the way it is integrated in the runtime code.
In my opinion it would be better to do it like webpack.
- if
crossOriginLoadingis truthy, adds thecrossOriginattribute - remove the
ifguard
In webpack, the runtime generation is different but you can look at the implementation here: https://github.com/webpack/webpack/blob/614a6fc0109a702ee64ca0b0982a0d638b1b6ca1/lib/web/JsonpMainTemplate.runtime.js#L19
|
@ooflorent In webpack it's similar. Also guarded by an if. It makes sure that cookies are send when requesting same-origin. see also webpack/webpack#7017 |
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good work, can we add test? Maybe manual
chikara-chan
force-pushed
the
master
branch
2 times, most recently
from
42fd988 to
273e2a8
Compare
|
Please accept CLA |
|
@evilebottnawi done |
|
@chikara-chan something wrong, looks you have difference emails in commits and in CLA |
|
@evilebottnawi Sign the CLA with the same email in success! |
ghost
mentioned this pull request
5 participants
This PR contains a:
Motivation / Use-Case
#312
Reference code. We could reuse Webpack output options.
Breaking Changes
Additional Info